NMS-16510: fix assert search #7450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smunir-onms
reviewed
Oct 1, 2024
opennms-config/src/main/java/org/opennms/netmgt/filter/JdbcFilterDao.java
Outdated
Show resolved
Hide resolved
cgorantla
changed the title
cgorantla
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Can you go back to https://docs.opennms.com/horizon/33/operation/deep-dive/search.html and see if there are other ways to solve this
| if(table == null) { | ||
| final String message = "Could not find the column '" + column +"' in filter rule"; | ||
| throw new FilterParseException(message); | ||
| if (doesColumnExist(column)) { |
There was a problem hiding this comment.
we are bypassing throwing exception and returning empty. Did you ensure this will not cause any issues in other parts of the code ?
Comment on lines
+461
to
+465
| //added table assets column | ||
| columns.append(", " + m_databaseSchemaConfigFactory.addColumn(tables, "city")); | ||
| columns.append(", " + m_databaseSchemaConfigFactory.addColumn(tables, "department")); | ||
| columns.append(", " + m_databaseSchemaConfigFactory.addColumn(tables, "address1")); | ||
|
|
There was a problem hiding this comment.
we can't keep on adding these columns as we desire. Also the search term was used in asset description.
|
we don't need this PR. Please see updates on the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External References