NMS-15859: Inherit basic SSL config props from the producer to the stream client. #6412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ream client. Also document the behavior and existence of the stream config.
Bonrob2
suggested changes
Jul 20, 2023
docs/modules/operation/pages/deep-dive/kafka-producer/configure-kafka.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/kafka-producer/configure-kafka.adoc
Outdated
Show resolved
Hide resolved
docs/modules/operation/pages/deep-dive/kafka-producer/configure-kafka.adoc
Outdated
Show resolved
Hide resolved
dino2gnt
previously approved these changes
Jul 20, 2023
There was a problem hiding this comment.
alarm-datasync-4ff962a7-05a9-47a0-9467-9bfba0afc4a5-GlobalStreamThread | GlobalStreamThread | 209 - org.apache.servicemix.bundles.kafka-clients - 3.3.1.1 | global-stream-thread [alarm-datasync-4ff962a7-05a9-47a0-9467-9bfba0afc4a5-GlobalStreamThread] State transition from CREATED to RUNNING
alarm-datasync-4ff962a7-05a9-47a0-9467-9bfba0afc4a5-GlobalStreamThread | KafkaStreams | 209 - org.apache.servicemix.bundles.kafka-clients - 3.3.1.1 | stream-client [alarm-datasync-4ff962a7-05a9-47a0-9467-9bfba0afc4a5] State transition from REBALANCING to RUNNING
kafka-producer-alarm-datasync-0 | KafkaStreams | 209 - org.apache.servicemix.bundles.kafka-clients - 3.3.1.1 | stream-client [alarm-datasync-4ff962a7-05a9-47a0-9467-9bfba0afc4a5] Started 0 stream threads
kafka-producer-alarm-datasync-0 | KafkaAlarmDataSync | 509 - org.opennms.features.kafka.producer - 31.0.6 | Starting alarm datasync started.
kafka-producer-alarm-datasync-0 | KafkaAlarmDataSync | 509 - org.opennms.features.kafka.producer - 31.0.6 | Waiting for alarm data store to be ready.
kafka-producer-alarm-datasync-0 | KafkaAlarmDataSync | 509 - org.opennms.features.kafka.producer - 31.0.6 | Alarm data store is ready!
Rad.
Co-authored-by: Bonrob2 <[email protected]>
mmahacek
reviewed
Aug 1, 2023
docs/modules/operation/pages/deep-dive/kafka-producer/configure-kafka.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| When producing alarms to a topic, we also automatically enable a Kafka Stream client to help synchronize the contents of the topic and ensure eventual consistency with the database. | ||
|
|
||
| The streams client takes different properties than the producer and requires a separate configuration map. |
There was a problem hiding this comment.
"streams client" or "stream client"? it's singular when mentioned in the previous sentence. (and captialized)
Co-authored-by: mmahacek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://opennms.atlassian.net/browse/NMS-15859
Also document the behavior and existence of the stream config.