NMS-15780: Admin Password Change Prompt

[synqotik]

Initial implementation of a password change prompt when the default admin user logs in with username admin, password admin.

• Update login page to check for “admin/admin” and redirect to Password Gate page

• Implement Password Gate page which allows user to either change password or skip

• Clicking “skip” will respect navigating to original target page (if it wasn’t just the login page)

• Refactored password change servlets to abstract base class since they contain much of the same functionality

• Fix integration and smoke tests to click “Skip” so they all still work

• Doesn’t include smoke test for this functionality and UI/UX will need review

Target branch is a feature branch. When smoke test and any UX changes have been implemented and merge to feature branch, will open a separate PR to merge to develop.

External References

• Jira (Issue Tracker): https://opennms.atlassian.net/browse/NMS-15780

[scthompsonopen]

Approving because my only comment is a nit. Just a note that this is my first time reviewing jsp based HTML/CSS/JS but it still made sense, and my review is for the FE portions only. Don't know enough Java to review those portions with any competence.

[scthompsonopen]

Super minor nit, but you're mixing inline styles and classes here, and also in the footer. Not a huge deal normally for a small one off but this looks like a new file and there's so much CSS just above this. :)

[synqotik]

Thanks for taking a look! Will wait til Ben or Christian review and approve due to the Java and server-side stuff, but wanted a FE dev to take a look as well :)

I will update this to use a CSS class here and possibly login.jsp in a subsequent PR.

[RangerRick]

Just tried it out, everything worked for me.

Skip button makes it easy enough to handle in smoke tests too. 👍

🐿️