NMS-15839: Measurements API: Include node metadata even if resource not found #6336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Measurements API returns metadata including information on nodes when responding to a query for resource attribute values, for example by the Grafana plugin Performance data source.
However if the requested resource is not found, for example because SNMP collection has not yet occurred on that node, then no node metadata is returned, even though the node metadata exists. When the Grafana plugin
nodeToLabel
function is used, it doesn't find the node metadata including the label name and so the label displays as the FS:FID. This causes the issue in https://opennms.atlassian.net/browse/HELM-427.This will return metadata for the node even if the resource was not found, if the
relaxed
flag was set.External References