Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMS-15839: Measurements API: Include node metadata even if resource not found #6336

Merged

Conversation

synqotik
Copy link
Contributor

@synqotik synqotik commented Jul 7, 2023

The Measurements API returns metadata including information on nodes when responding to a query for resource attribute values, for example by the Grafana plugin Performance data source.

However if the requested resource is not found, for example because SNMP collection has not yet occurred on that node, then no node metadata is returned, even though the node metadata exists. When the Grafana plugin nodeToLabel function is used, it doesn't find the node metadata including the label name and so the label displays as the FS:FID. This causes the issue in https://opennms.atlassian.net/browse/HELM-427.

This will return metadata for the node even if the resource was not found, if the relaxed flag was set.

External References

Copy link
Contributor

@RangerRick RangerRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, wonder if this should go back to at least 2023 though since it would be nice to have it work for meridian users as well

@synqotik synqotik merged commit 4958986 into release-32.x Jul 7, 2023
4 checks passed
@synqotik synqotik deleted the jira/NMS-15839-measurement-api-include-node-metadata branch July 7, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants