sonar feedback: don't throw generic exceptions in servlets

OpenNMS · Jul 14, 2023 · c8a180c · c8a180c
1 parent 34f4a90
commit c8a180c
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/opennms-webapp/src/main/java/org/opennms/web/admin/discovery/ActionDiscoveryServlet.java b/opennms-webapp/src/main/java/org/opennms/web/admin/discovery/ActionDiscoveryServlet.java
@@ -327,7 +327,8 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
             }
 
             if (proxy == null) {
-                throw new IllegalStateException("unable to get event proxy");
+                response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, "unable to get event proxy");
+                return;
             }
 
             EventBuilder bldr = new EventBuilder(EventConstants.DISCOVERYCONFIG_CHANGED_EVENT_UEI, "ActionDiscoveryServlet");