NMS-15504: Prevent angular expr eval without app

Do not spawn a default app when there is no real app end prevent evaluation of angular expressions if no app is defined.
OpenNMS · Jul 17, 2023 · 13a3683 · 13a3683
1 parent 5a3b0b6
commit 13a3683
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/opennms-webapp/src/main/webapp/WEB-INF/templates/navbar.ftl b/opennms-webapp/src/main/webapp/WEB-INF/templates/navbar.ftl
@@ -32,7 +32,9 @@
             </ul>
         </#if>
 
-        <onms-central-search></onms-central-search>
+        <div ng-app="onms.default.apps">
+            <onms-central-search></onms-central-search>
+	</div>
 
         <ul class="navbar-nav ml-auto">
   		  <#if request.remoteUser?has_content >

diff --git a/opennms-webapp/src/main/webapp/includes/bootstrap.jsp b/opennms-webapp/src/main/webapp/includes/bootstrap.jsp
@@ -213,7 +213,7 @@
     ng-app="${param.ngapp}"
   </c:when>
   <c:otherwise>
-    ng-app="onms.default.apps"
+    ng-non-bindable
   </c:otherwise>
 </c:choose>
 <c:if test="${param.scrollSpy != null}">