Skip to content

Commit

Permalink
move the sample plugin to a separate feature
Browse files Browse the repository at this point in the history
Otherwise, things using the oia features file for validating features
need to download all the sample plugin artifacts.
  • Loading branch information
Benjamin Reed committed May 31, 2023
1 parent b7da1ed commit 1b3b7b0
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 1 deletion.
15 changes: 14 additions & 1 deletion karaf-features/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
<name>OpenNMS Integration API :: Karaf Features</name>
<packaging>pom</packaging>

<properties>
<!-- override to latest stable for newest validation code -->
<karaf.version>4.4.3</karaf.version>
</properties>

<build>
<plugins>
<plugin>
Expand Down Expand Up @@ -49,6 +54,11 @@
<file>${project.build.outputDirectory}/features.xml</file>
<type>xml</type>
</artifact>
<artifact>
<file>${project.build.outputDirectory}/sample.xml</file>
<classifier>sample</classifier>
<type>xml</type>
</artifact>
</artifacts>
</configuration>
</execution>
Expand All @@ -72,14 +82,17 @@
<descriptor>mvn:org.apache.karaf.features/framework/${karaf.version}/xml/features</descriptor>
<descriptor>mvn:org.apache.karaf.features/standard/${karaf.version}/xml/features</descriptor>
<descriptor>file:${project.build.directory}/classes/features.xml</descriptor>
<descriptor>file:${project.build.directory}/classes/sample.xml</descriptor>
</descriptors>
<distribution>org.apache.karaf.features:framework</distribution>
<framework>
<feature>framework</feature>
</framework>
<features>
<feature>opennms-integration-api</feature>
<feature>sample-plugin-common</feature>
<feature>opennms-plugin-sample</feature>
<feature>minion-plugin-sample</feature>
<feature>sentinel-plugin-sample</feature>
</features>
</configuration>
</execution>
Expand Down
26 changes: 26 additions & 0 deletions karaf-features/src/main/resources/sample.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<features name="opennms-integration-api-sample-plugin" xmlns="http://karaf.apache.org/xmlns/features/v1.4.0">
<repository>mvn:org.opennms.integration.api/karaf-features/${project.version}/xml</repository>

<feature name="sample-plugin-common" description="Sample Plugin :: Common" version="${project.version}">
<feature version="${project.version}" dependency="true">opennms-integration-api</feature>
<bundle dependency="true">mvn:commons-io/commons-io/${commonsIoVersion}</bundle>
<bundle>mvn:org.opennms.integration.api.sample/sample-project/${project.version}</bundle>
</feature>

<feature name="opennms-plugin-sample" description="Sample Plugin :: OpenNMS" version="${project.version}">
<feature version="${project.version}">sample-plugin-common</feature>
<bundle>blueprint:mvn:org.opennms.integration.api.sample/sample-project/${project.version}/xml/blueprint-core</bundle>
</feature>

<feature name="minion-plugin-sample" description="Sample Plugin :: Minion" version="${project.version}">
<feature version="${project.version}">sample-plugin-common</feature>
<bundle>blueprint:mvn:org.opennms.integration.api.sample/sample-project/${project.version}/xml/blueprint-minion</bundle>
</feature>

<feature name="sentinel-plugin-sample" description="Sample Plugin :: Sentinel" version="${project.version}">
<feature version="${project.version}">sample-plugin-common</feature>
<bundle>blueprint:mvn:org.opennms.integration.api.sample/sample-project/${project.version}/xml/blueprint-sentinel</bundle>
</feature>

</features>

0 comments on commit 1b3b7b0

Please sign in to comment.