Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Upload with Force Replace #9072

Open
wants to merge 43 commits into
base: dev
Choose a base branch
from

Conversation

…ng a unique key

[tests/unit] adding a test to delete and reupload a dataset with the same name
- fix bug `dataset.get_all` shows deleted dataset (now only show if specify with a flag)
- improve repr_html of deleted datasets
- test force_replace functionality in `test_reupload_dataset`
@khoaguin
Copy link
Member Author

khoaguin commented Jul 24, 2024

use include_deleted to list / not list the deleted dataset
Screenshot from 2024-07-24 08-52-43

@khoaguin
Copy link
Member Author

repr for deleted dataset:
image

@khoaguin khoaguin force-pushed the upload-dataset-with-force-replace branch from 6f20526 to bfe674a Compare July 24, 2024 02:19
…asets to DatasetStash.get_all

- continue implementing uploading with force replace
[tests/unit] modify test_reupload_dataset to reflect new changes
… that uploads a dataset's assets into a separate function
@shubham3121 shubham3121 self-requested a review August 12, 2024 05:54
@khoaguin
Copy link
Member Author

khoaguin commented Sep 11, 2024

Got this error after merging with dev:
image
probably due to bugs in _update and _remove_keys of KeyValueStorePartition called by services.dataset.delete.

Will fix and merge this PR after changing database to PostgreSQL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants