Creating Additive mechanism from standard deviation #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
changed the title
monsieurmuffin
approved these changes
Jul 25, 2023
pipeline_dp/dp_computations.py
Outdated
| return (f"Gaussian mechanism: parameter={self.noise_parameter} eps=" | ||
| f"{self._mechanism.epsilon} delta={self._mechanism.delta} " | ||
| f"l2_sensitivity={self.sensitivity}") | ||
| if self._mechanism.epsilon > 0: # todo comment |
There was a problem hiding this comment.
looks like a forgotten TODO
|
Thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, it was possible to create
AdditiveMechanism(Laplace or Gausisan) only from (eps, delta). This PR implements possibility to create from sttdev. It's needed for using PLD for budget accounting, which will be added in the subsequent PR.