Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Refactoring) Drop AdditiveMechanismSpec, use MechanismSpec instead #464

Merged
merged 1 commit into from
Jun 29, 2023
Merged

(Refactoring) Drop AdditiveMechanismSpec, use MechanismSpec instead #464

merged 1 commit into from
Jun 29, 2023

Conversation

dvadym
Copy link
Collaborator

@dvadym dvadym commented Jun 29, 2023 •
edited
Loading

Having 2 very similar classes AdditiveMechanismSpec and MechanismSpec adds confusions and complexity, while doesn't add any benefits. Let's drop the former and let's use MechanismSpec.

Also it contains

  1. test renaming, dropping "_new", which is leftover from tune_new (which was renamed to tune).
  2. increase acceptance range for a stat tests (in tests/combiners_test.py).

@dvadym dvadym merged commit 69372bd into main Jun 29, 2023
10 of 11 checks passed
@delete-merged-branch delete-merged-branch bot deleted the simplify_additive_mechanism branch June 29, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurmuffin monsieurmuffin monsieurmuffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvadym @monsieurmuffin