Rector: CQ - UnusedForeachValueToArrayKeysRector #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Rector\CodeQuality\Rector\Foreach_\UnusedForeachValueToArrayKeysRector
See fix at rector: rectorphp/rector-src#6164
github-actions
bot
added
Component: PayPal
addison74
approved these changes
Jul 22, 2024
empiricompany
approved these changes
Jul 26, 2024
kiatng
reviewed
Aug 7, 2024
kiatng
reviewed
Aug 7, 2024
app/code/core/Mage/Adminhtml/Model/System/Config/Source/Admin/Page.php
Outdated
Show resolved
Hide resolved
sreichel
added a commit
to sreichel/magento-lts
that referenced
this pull request
Aug 7, 2024
kiatng
previously approved these changes
Aug 9, 2024
addison74
previously approved these changes
Aug 9, 2024
# Conflicts: # dev/tests/functional/tests/app/Mage/Adminhtml/Test/Block/Catalog/Product/Attribute/Edit/AttributeForm.php # dev/tests/functional/tests/app/Mage/Adminhtml/Test/Block/Catalog/Product/Edit/Tab/Prices.php # dev/tests/functional/tests/app/Mage/Adminhtml/Test/Block/Catalog/Product/ProductForm.php # dev/tests/functional/tests/app/Mage/Adminhtml/Test/Block/Widget/FormTabs.php # dev/tests/functional/tests/app/Mage/Bundle/Test/Handler/Curl.php # dev/tests/functional/tests/app/Mage/Catalog/Test/TestStep/UpdateConfigurableProductStep/DeleteOptionsSubStep.php # dev/tests/functional/tests/app/Mage/Customer/Test/Handler/Customer/Curl.php # dev/tests/functional/tests/app/Mage/Weee/Test/Constraint/AssertFptApplied.php
kiatng
previously approved these changes
Sep 6, 2024
addison74
approved these changes
Sep 6, 2024
kiatng
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code step by step using rector ...
See https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#unusedforeachvaluetoarraykeysrector
Edit: there are some comments that state to dislike it - for personal prefs, for readability, for not having used it before ...
Imho ... it makes the code better. PHPMD will not complain about unused local variables. It makes it more readable, b/c i can see we deal only with the array keys. This sniff could be excluded, but isnt it better to make use of quality tools w/o ignore some rules?