Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/refund bundle items #3708

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eneiasramos
Copy link
Contributor

@eneiasramos eneiasramos commented Dec 24, 2023

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@eneiasramos
Copy link
Contributor Author

When we try to refund a bundle item we get this error. The PR fix this.

image

@github-actions github-actions bot added the Component: Sales Relates to Mage_Sales label Dec 26, 2023
@luigifab
Copy link
Contributor

Strange, I never got any errors like this one when refunding.

@eneiasramos
Copy link
Contributor Author

Strange, I never got any errors like this one when refunding.

Bundle order items?

@luigifab
Copy link
Contributor

luigifab commented Feb 2, 2024

Yes.

@eneiasramos
Copy link
Contributor Author

Could you post the evidence here please?

@fballiano
Copy link
Contributor

@eneiasramos do you have this in production? the tests needed here worry me a bit since it's a very important part of the system

@eneiasramos
Copy link
Contributor Author

@fballiano Yes, it is a productive system.

The problem is because both base_row_total and row_total fields are not filled.

@fballiano
Copy link
Contributor

fballiano commented Apr 24, 2024

I tested this scenario but I can't reproduce the error:

  • openmage main with sample data
  • create an order with bundle product (camera travel set)
  • invoiced it
  • created credit memo for this product (the only one in the order)
  • credit memo created with no problem

I see that you're using a different currency, do you have the same currency for the whole project or you have different currencies in a multistore environment?

edit: screenshot of the creditmemo:
Screenshot 2024-04-24 alle 09 35 20

@eneiasramos
Copy link
Contributor Author

@fballiano

Could you please share a screenshot of your order, so I can compare the information between the credit memo and the order itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Relates to Mage_Sales
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants