Shipping Method cannot calculate shipping costs based on "tax_subtotal" of the quote

[EliasKotlyar]

Fixed Issues (if relevant)

1. Fixes Shipping Method cannot calculate shippingcosts based on "tax_subtotal" of the quote #3407

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[addison74]

I am using this configuration by keeping only "freeshipping" in my installations. This tag <after>freeshipping</after> can also be found in Magento 1.9.4.5, after it was modified throughout the versions. There were discussions in OpenMage and it came to those 4 added, which in my case generates problems.

The best solution in this case is not the modification proposed in this PR, but offering in the Backend the possibility of setting them up in a multiselect field. Thus, if someone has problems with taxes, he can deselect the other options and stay only with the desired ones.

As it is now, it is hardcoded and there will be people who want the change (my case) and others who don't want it.

[fballiano]

@addison74 genuine question, I fail to understand what "Shipping Method cannot calculate shipping costs based on tax_subtotal" means, like, where is the problem happening? I don't know that part of openmage and I can't understand how important this problem really is

[fballiano]

also, the commit that made this change originally seems to be d92a24a, which, in my opinion, is a mistake because the latest version of the tax/config.xml is clearly different.

this is really weird but it scares me a bit to approve this change

[addison74]

It's been a while since we discussed this topic. I encountered problems with the setting in Magento vanilla, then with the one in OpenMage. I didn't have time to check in detail what was happening, but the problem was immediately solved by the modification shown above. Please check #3407 for more information and links to other discussions have been provided. I think there are not only those 4 options, but more. It would be ideal to be able to configure them in the Backend as a multiselect list.