24.0.3 release #497
Merged
24.0.3 release #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awisniew90
force-pushed
the
1Q24-release
branch
from
93fe77a
to
a450315
Compare
scottkurz
requested changes
Feb 8, 2024
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | ||
| <?pde version="3.8"?> | ||
| <!-- | ||
| Copyright (c) 2023 IBM Corporation and others. |
docs/user-guide.md
Outdated
| @@ -44,6 +44,7 @@ This guide provides detailed instructions on how to use Liberty Tools for the Ec | |||
| | 23.0.7 | 2023-03 - Eclipse v4.27 | | |||
| | 23.0.9 | 2023-06 - Eclipse v4.28 | | |||
| | 23.0.12 | 2023-09 - Eclipse v4.29 | | |||
| | 24.0.3 | 2023-12 - Eclipse v4.30 | | |||
| <unit id="org.eclipse.lsp4mp.jdt.core" version="0.10.0.20231005-1230"/> | ||
| </location> | ||
| <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <repository location="https://download.eclipse.org/lsp4jakarta/snapshots/0.2.0/repository"/> |
There was a problem hiding this comment.
Should this be: snapshots->releases?
| <location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit"> | ||
| <repository location="https://download.eclipse.org/releases/2023-12/"/> | ||
| <!-- The following units will use versions included in the Eclipse 4Q2023 release --> | ||
| <unit id="org.eclipse.jdt.feature.group" version="0.0.0"/> |
There was a problem hiding this comment.
What is the reason for switching to 0.0.0? Is it just to avoid having to go through the trouble of listing out versions unit-by-unit? I thought the Eclipse PDE tools helped us with this. I guess it's maybe useful to have this as documentation ( a record) of the versions we're testing against, e.g. even for something like the lsp4e-related versions. I don't think it hugely matters in that I'm not sure the contents are ever updated (are they??? Do we know that 100% for a fact)?
awisniew90
force-pushed
the
1Q24-release
branch
10 times, most recently
from
8f6d8ee
to
05b484e
Compare
awisniew90
force-pushed
the
1Q24-release
branch
6 times, most recently
from
f2cb18b
to
6d7832e
Compare
24.0.3 release Signed-off-by: Adam Wisniewski <[email protected]> Adjust basedir Signed-off-by: Scott Kurz <[email protected]> 24.0.3 release Signed-off-by: Adam Wisniewski <[email protected]> remove println Signed-off-by: Adam Wisniewski <[email protected]>
awisniew90
force-pushed
the
1Q24-release
branch
from
6d7832e
to
effc7be
Compare
…liberty.tools.eclipse.mvnlogfilename' property, triggered via tests by '-DmvnLogFile' and enabled in GHA runs. Signed-off-by: Scott Kurz <[email protected]>
Add .m2 directory Signed-off-by: Adam Wisniewski <[email protected]> Add cdt.launch unit Signed-off-by: Adam Wisniewski <[email protected]>
awisniew90
force-pushed
the
1Q24-release
branch
8 times, most recently
from
3e72097
to
c0ad415
Compare
awisniew90
force-pushed
the
1Q24-release
branch
3 times, most recently
from
824248d
to
751640f
Compare
scottkurz
reviewed
Feb 27, 2024
tests/src/main/java/io/openliberty/tools/eclipse/test/it/AbstractLibertyPluginSWTBotTest.java
Outdated
Show resolved
Hide resolved
scottkurz
requested changes
Feb 27, 2024
| @@ -18,6 +18,7 @@ | |||
| import java.net.URL; | |||
ci/jenkins/run-tests
Outdated
| git branch: 'main', | ||
| url: 'https://github.com/OpenLiberty/liberty-tools-eclipse.git' | ||
| git branch: '1Q24-release', | ||
| url: 'https://github.com/awisniew90/liberty-tools-eclipse.git' |
There was a problem hiding this comment.
right - just to test out our jenkins path.... in Jenkins, we can point to my forked branch to test with, but we clone from "main" for the test code. I put some thought into how we can change this, but it's not often enough we do this to warrant the time to fix.
Signed-off-by: Adam Wisniewski <[email protected]>
awisniew90
force-pushed
the
1Q24-release
branch
6 times, most recently
from
53a0e94
to
bbd0560
Compare
|
All of our tests use either Java 11 or 8.. maybe if we still have work to do we could switch one of these to '17'? |
awisniew90
force-pushed
the
1Q24-release
branch
from
bbd0560
to
3bb7b41
Compare
Signed-off-by: Adam Wisniewski <[email protected]>
awisniew90
force-pushed
the
1Q24-release
branch
from
3bb7b41
to
034d900
Compare
Signed-off-by: Adam Wisniewski <[email protected]>
scottkurz
approved these changes
Feb 28, 2024
Closed
|
Resolves issue #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update LTE versions to 24.0.3
Create new 4Q2023 target platform
Switch tests to use new 4Q2023 target as default