Provide option to run LT plugin stop comand when the stop action is used #412
Conversation
scottkurz
force-pushed
the
issueLPStopCmd
branch
2 times, most recently
from
3de04c7
to
14fbf4f
Compare
…elected Signed-off-by: Edward Mezarina <[email protected]>
scottkurz
force-pushed
the
issueLPStopCmd
branch
2 times, most recently
from
aa3f057
to
b95ef07
Compare
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
| /* | ||
| * Check for bad exit value | ||
| */ | ||
| Object rc = event.getJob().getProperty(STOP_JOB_COMPLETION_EXIT_CODE); |
There was a problem hiding this comment.
The rc value can be null if the job is cancelled before it completes. Line 867 will exit the job and one would get a message with a null exit value: "Stop failed with exitValue = null ...". Also the message can be a bit misleading in this case (stop may have worked because of timing), so perhaps along with checking the the rc value for null, etc, perhaps no message would be better unless we detected that the cancel failed?
| /** | ||
| * Cancel running jobs and avoid error message, e.g. on closing Eclipse IDE | ||
| */ | ||
| public void cancelRunningJobs() { |
There was a problem hiding this comment.
This method seems like it should be removing the jobs from the map and cancelling them.
There was a problem hiding this comment.
OK, thought this map was going away anyway but I'll add a clear() at the end.
There was a problem hiding this comment.
Actually, the JobChangeAdapter.done() will remove the job so it's not really needed.
Signed-off-by: Scott Kurz <[email protected]>
Fixes #248
NOTE: I use the phrase "the Liberty Maven or Gradle stop command" in user-facing error messages. I know we've also tried the phrase "Liberty plugin stop" to abstract across each of Maven/Gradle. I wonder if it's obvious that that means "Liberty Maven or Gradle plugin" (which we could also write), however.