Add LSP4Jakarta tests #407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottkurz
requested changes
Jun 22, 2023
| @@ -0,0 +1,202 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2022, 2023 IBM Corporation and others. | |||
| @@ -35,6 +35,19 @@ | |||
| <version>3.1.0</version> | |||
| <scope>provided</scope> | |||
| </dependency> | |||
scottkurz
reviewed
Jun 26, 2023
| @@ -13,7 +13,7 @@ | |||
| --> | |||
| <server description="Sample Servlet server"> | |||
| <featureManager> | |||
| <feature>jsp-2.3</feature> | |||
| <feature>jakartaee-10.0</feature> | |||
There was a problem hiding this comment.
If we're actually starting the server (as I think we do in some of these tests), using the platform feature will add significantly more startup time. Better to stick with the EE 9/10-equivalent: pages-3.0/3.1
awisniew90
force-pushed
the
lsp_tests
branch
6 times, most recently
from
4a540f6
to
ee1b6a0
Compare
scottkurz
reviewed
Jun 29, 2023
tests/pom.xml
Outdated
| @@ -38,6 +38,7 @@ | |||
| <useUIThread>false</useUIThread> | |||
| <providerHint>junit5</providerHint> | |||
| <trimStackTrace>false</trimStackTrace> | |||
| <testRuntime>p2Installed</testRuntime> | |||
scottkurz
reviewed
Jun 29, 2023
| @@ -102,6 +103,16 @@ | |||
| <id>org.eclipse.lsp4e.jdt</id> | |||
| <versionRange>0.0.0</versionRange> | |||
| </requirement> | |||
| <requirement> | |||
There was a problem hiding this comment.
We have one for lsp4mp but not lsp4jakarta?
awisniew90
force-pushed
the
lsp_tests
branch
4 times, most recently
from
90421a4
to
7436fba
Compare
awisniew90
force-pushed
the
lsp_tests
branch
3 times, most recently
from
cc9381c
to
eda08f1
Compare
added 5 commits
September 19, 2023 10:52
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
awisniew90
force-pushed
the
lsp_tests
branch
from
eda08f1
to
224112f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic LSP4Jakarta tests for snippets, diagnostics, and quick fixes