Adding support to turn off the blinking light after a while #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem is up and running. This is a configurable number from 0-99 with 0 being to blink as normal (and is the default). Also updated the firmware version to 1.2.2 since it seems like this was missed for 1.2.1.
…nt with the rest of the file
jknaack
commented
Jun 30, 2023
| @@ -24,7 +24,7 @@ | |||
| #define _DEFINES_H | |||
|
|
|||
| /** Firmware version, hardware version, and maximal values */ | |||
| #define OG_FWV 120 // Firmware version: 120 means 1.2.0 | |||
| #define OG_FWV 122 // Firmware version: 122 means 1.2.2 | |||
There was a problem hiding this comment.
This fixes #79, at least going forward
…ng the light off. Also moving the blink ticker times to the defines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if you are taking new feature submissions or not anymore, but I added the ability to disable the blinking light after a specified number of blinks. The /jo and /co urls have been updated to get/set the value, and a menu item has been added to the Basic Options page to allow it to be modified easily.
When setting up the device, or after a reboot, the blinks are handy to know things are working, but after a while, I find them distracting. The default setting is a "blink count" of 0, which means forever, just like it does today. From 1-99 will blink that many times, and then stop blinking until the read counter hits that number (read_count has a limit of 99, which is where the limit comes from; that said, if you want more than 99, you probably just want "forever" anyway).
I also updated the firmware version to 1.2.2.
Also fixes #79