Merge pull request #41 from PSNAppz/1.0

Return None if disbursement id is invalid or not found
OpenG2P · Oct 16, 2024 · 909408d · 909408d
2 parents c076aa3 + c536d6e
commit 909408d
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...-g2p-bridge-celery-workers/src/openg2p_g2p_bridge_celery_workers/tasks/mt940_processor.py b/...-g2p-bridge-celery-workers/src/openg2p_g2p_bridge_celery_workers/tasks/mt940_processor.py
@@ -316,9 +316,10 @@ def get_bank_batch_id(parsed_transaction, session):
             == parsed_transaction["disbursement_id"]
         )
         .first()
-        .bank_disbursement_batch_id
     )
-    return bank_disbursement_batch_id
+    if not bank_disbursement_batch_id:
+        return None
+    return bank_disbursement_batch_id.bank_disbursement_batch_id
 
 
 def construct_disbursement_error_recon(
@@ -452,6 +453,9 @@ def get_disbursement_envelope_id(disbursement_id, session):
         .first()
     )
 
+    if not disbursement:
+        return None
+
     return disbursement.disbursement_envelope_id