Add logging to all methods

OpenG2P · Aug 7, 2024 · 5d6f13e · 5d6f13e
1 parent 8e85cfd
commit 5d6f13e
Showing 1 changed file with 30 additions and 1 deletion.
diff --git a/...nnectors/src/openg2p_g2p_bridge_bank_connectors/bank_connectors/example_bank_connector.py b/...nnectors/src/openg2p_g2p_bridge_bank_connectors/bank_connectors/example_bank_connector.py
@@ -1,4 +1,5 @@
 from typing import List, Optional
+import logging
 
 import httpx
 from openg2p_g2p_bridge_models.models import (
@@ -18,7 +19,7 @@
 from ..config import Settings
 
 _config = Settings.get_config()
-
+_logger = logging.getLogger(_config.logging_default_logger_name)
 
 class BankPaymentPayload(BaseModel):
     payment_reference_number: str
@@ -52,6 +53,9 @@ class BankPaymentPayload(BaseModel):
 
 class ExampleBankConnector(BankConnectorInterface):
     def check_funds(self, account_number, currency, amount) -> CheckFundsResponse:
+        _logger.info(
+            f"Checking funds availability for account_number: {account_number}, currency: {currency}, amount: {amount}"
+        )
         try:
             with httpx.Client() as client:
                 request_data = {
@@ -66,18 +70,30 @@ def check_funds(self, account_number, currency, amount) -> CheckFundsResponse:
 
                 data = response.json()
                 if data["status"] == "success":
+                    _logger.info(
+                        f"Funds available for account_number: {account_number}, currency: {currency}, amount: {amount}"
+                    )
                     return CheckFundsResponse(
                         status=FundsAvailableWithBankEnum.FUNDS_AVAILABLE, error_code=""
                     )
+                _logger.info(
+                    f"Funds not available for account_number: {account_number}, currency: {currency}, amount: {amount}"
+                )
                 return CheckFundsResponse(
                     status=FundsAvailableWithBankEnum.FUNDS_NOT_AVAILABLE, error_code=""
                 )
         except httpx.HTTPStatusError as e:
+            _logger.error(
+                f"Error checking funds availability for account_number: {account_number}, currency: {currency}, amount: {amount}"
+            )
             return CheckFundsResponse(
                 status=FundsAvailableWithBankEnum.PENDING_CHECK, error_code=str(e)
             )
 
     def block_funds(self, account_number, currency, amount) -> BlockFundsResponse:
+        _logger.info(
+            f"Blocking funds for account_number: {account_number}, currency: {currency}, amount: {amount}"
+        )
         try:
             with httpx.Client() as client:
                 request_data = {
@@ -92,17 +108,26 @@ def block_funds(self, account_number, currency, amount) -> BlockFundsResponse:
 
                 data = response.json()
                 if data["status"] == "success":
+                    _logger.info(
+                        f"Funds blocked for account_number: {account_number}, currency: {currency}, amount: {amount}"
+                    )
                     return BlockFundsResponse(
                         status=FundsBlockedWithBankEnum.FUNDS_BLOCK_SUCCESS,
                         block_reference_no=data["block_reference_no"],
                         error_code="",
                     )
+                _logger.error(
+                    f"Funds block failed for account_number: {account_number}, currency: {currency}, amount: {amount}"
+                )
                 return BlockFundsResponse(
                     status=FundsBlockedWithBankEnum.FUNDS_BLOCK_FAILURE,
                     block_reference_no="",
                     error_code=data.get("error_code", ""),
                 )
         except httpx.HTTPStatusError as e:
+            _logger.error(
+                f"Error blocking funds for account_number: {account_number}, currency: {currency}, amount: {amount}"
+            )
             return BlockFundsResponse(
                 status=FundsBlockedWithBankEnum.FUNDS_BLOCK_FAILURE,
                 block_reference_no="",
@@ -112,6 +137,7 @@ def block_funds(self, account_number, currency, amount) -> BlockFundsResponse:
     def initiate_payment(
         self, disbursement_payment_payloads: List[DisbursementPaymentPayload]
     ) -> PaymentResponse:
+        _logger.info(f"Initiating payment for {len(disbursement_payment_payloads)} disbursements")
         try:
             with httpx.Client() as client:
                 bank_payment_payloads = []
@@ -152,11 +178,14 @@ def initiate_payment(
 
                 data = response.json()
                 if data["status"] == "success":
+                    _logger.info(f"Payment initiated successfully")
                     return PaymentResponse(status=PaymentStatus.SUCCESS, error_code="")
+                _logger.error(f"Payment initiation failed")
                 return PaymentResponse(
                     status=PaymentStatus.ERROR, error_code=data.get("error_message", "")
                 )
         except httpx.HTTPStatusError as e:
+            _logger.error(f"Error initiating payment: {e}")
             return PaymentResponse(status=PaymentStatus.ERROR, error_code=str(e))
 
     def retrieve_disbursement_id(