Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Test_C2 #1339

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Adding Test_C2 #1339

merged 2 commits into from
Sep 22, 2024

Conversation

Rakesh-Ranga-Buram
Copy link
Contributor

Description

I added the test case C2 following the test documentation. This test is meant for testing the "Quantity meter". The specifications like slope, shift, start compare, end compare are all written following the details in the test documentation

Partially Addresses #962

Type of change

(Check the ones that apply by placing an "x" instead of the space in the [ ] so it becomes [x])

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @mmehta2669 for their first contribution (and @Rakesh-Ranga-Buram for the pull request). The code is good and it works as expected. I have made one very small comment to address.

src/server/test/web/readingsCompareMeterQuantity.js Outdated Show resolved Hide resolved
I removed the add C2 comment
Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @mmehta2669 for the change. Everything looks good. Congratulations on your first accepted contribution.

@huss huss merged commit acf8dac into OpenEnergyDashboard:development Sep 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants