Add VisualUnitsComponent #1328
Add VisualUnitsComponent #1328
Conversation
There was a problem hiding this comment.
Thanks to @nlin21 for moving this forward. I like the way it works and testing found no issues. As noted there are a several items for the next person to finish up to finalize this.
I made a few comments that can be addressed if you have the time. They are fairly straightforward.
| @@ -1016,6 +1017,7 @@ const LocaleTranslationData = { | |||
| "uses": "uses\u{26A1}", | |||
| "view.groups": "Visionner les groupes", | |||
| "visit": " ou visitez notre ", | |||
| "visual-unit": "Visual Units Graph.\u{26A1}", | |||
There was a problem hiding this comment.
No period in English so not here or Spanish.
| import CreateVisualUnitMapModalComponent from './CreateVisualUnitModalMapComponent'; | ||
|
|
||
| /** | ||
| * Defines the units page card view |
| <div className='container-fluid'> | ||
| <h2 style={titleStyle}> | ||
| <FormattedMessage id='visual-unit' /> | ||
| {/* <div style={tooltipStyle}> |
There was a problem hiding this comment.
It is okay to have the tooltip visible. OED will add the needed help page.
| nodes: [], | ||
| links: [] | ||
| }; | ||
| unitData.map(function (value) { |
There was a problem hiding this comment.
This is fine but I think most code in OED uses implicit functions rather than using the name.
| links: [] | ||
| }; | ||
| unitData.map(function (value) { | ||
| data.nodes.push({'name': value.name, |
There was a problem hiding this comment.
Maybe put the first item on its own line to be consistent with below and to make them line up.
| data.links.push({ | ||
| 'source': value.sourceId, | ||
| 'target': value.destinationId, | ||
| 'bidirectional': value.bidirectional /* boolean value */ |
There was a problem hiding this comment.
OED likes comments on the line above and not at the end of the line. Applies to other lines too.
Description
This visual is implemented with D3.js, using units and conversions data pulled from redux.
Partly fixes #1224
For future development:
Type of change
Checklist
(Note what you have done by placing an "x" instead of the space in the [ ] so it becomes [x]. It is hoped you do all of them.)
Limitations