linux-dpdk: pool: add checks for internal event header sizes

Add compile time checks for implementation internal event header sizes. Detect if a size of an event header expands to a new cache line, as this may have significant performance implications. RTE_CACHE_LINE_SIZE is used instead of ODP_CACHE_LINE_SIZE because in ABI compat mode the values may differ. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
OpenDataPlane · Aug 31, 2023 · c11b278 · c11b278
1 parent 5d505fd
commit c11b278
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/platform/linux-dpdk/include/odp_buffer_internal.h b/platform/linux-dpdk/include/odp_buffer_internal.h
@@ -60,6 +60,9 @@ typedef struct ODP_ALIGNED_CACHE odp_buffer_hdr_t {
 
 } odp_buffer_hdr_t;
 
+ODP_STATIC_ASSERT(sizeof(odp_buffer_hdr_t) <= 3 * RTE_CACHE_LINE_SIZE,
+		  "Additional cache line required for odp_buffer_hdr_t");
+
 static inline struct rte_mbuf *_odp_buf_to_mbuf(odp_buffer_t buf)
 {
 	return (struct rte_mbuf *)(uintptr_t)buf;

diff --git a/platform/linux-dpdk/include/odp_event_vector_internal.h b/platform/linux-dpdk/include/odp_event_vector_internal.h
@@ -21,6 +21,8 @@
 
 #include <odp_event_internal.h>
 
+#include <rte_config.h>
+
 #include <stdint.h>
 
 /**
@@ -47,6 +49,9 @@ typedef struct ODP_ALIGNED_CACHE odp_event_vector_hdr_t {
 
 } odp_event_vector_hdr_t;
 
+ODP_STATIC_ASSERT(sizeof(odp_event_vector_hdr_t) <= 3 * RTE_CACHE_LINE_SIZE,
+		  "Additional cache line required for odp_event_vector_hdr_t");
+
 /**
  * Return the vector header
  */

diff --git a/platform/linux-dpdk/include/odp_packet_internal.h b/platform/linux-dpdk/include/odp_packet_internal.h
@@ -184,6 +184,9 @@ typedef struct ODP_ALIGNED_CACHE odp_packet_hdr_t {
 	uint8_t crypto_aad_buf[PACKET_AAD_MAX];
 } odp_packet_hdr_t;
 
+ODP_STATIC_ASSERT(sizeof(odp_packet_hdr_t) <= 6 * RTE_CACHE_LINE_SIZE,
+		  "Additional cache line required for odp_packet_hdr_t");
+
 /**
  * Return the packet header
  */

diff --git a/platform/linux-dpdk/include/odp_timer_internal.h b/platform/linux-dpdk/include/odp_timer_internal.h
@@ -22,6 +22,8 @@
 #include <odp_global_data.h>
 #include <odp_pool_internal.h>
 
+#include <rte_config.h>
+
 /**
  * Internal Timeout header
  */
@@ -46,6 +48,9 @@ typedef struct ODP_ALIGNED_CACHE odp_timeout_hdr_t {
 
 } odp_timeout_hdr_t;
 
+ODP_STATIC_ASSERT(sizeof(odp_timeout_hdr_t) <= 3 * RTE_CACHE_LINE_SIZE,
+		  "Additional cache line required for odp_timeout_hdr_t");
+
 /* A larger decrement value should be used after receiving events compared to
  * an 'empty' call. */
 void _odp_timer_run_inline(int dec);