Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Add remote logout_remote value to openId options (#7766) #8466

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

aHenryJard
Copy link
Member

Proposed changes

  • As suggested in issue add logout_remote in OpenID options.

Tested locally with OpenID and SAML authentication.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.21%. Comparing base (2dd7701) to head (3e8da43).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...i-platform/opencti-graphql/src/config/providers.js 0.00% 2 Missing ⚠️
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8466      +/-   ##
==========================================
- Coverage   66.21%   66.21%   -0.01%     
==========================================
  Files         597      597              
  Lines       60422    60425       +3     
  Branches     6204     6207       +3     
==========================================
  Hits        40010    40010              
- Misses      20412    20415       +3     
Flag Coverage Δ
66.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard merged commit a8de5b5 into master Sep 27, 2024
6 checks passed
@aHenryJard aHenryJard deleted the issue/7766-oidc-logout branch September 27, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OIDC logout remote not working
2 participants