Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add button for selecting relationships in knowledge graph #8447

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

stefan1anuby
Copy link
Contributor

Proposed changes

Added a button to select/deselect relationships (children/parent/both) from or to selected nodes in a knowledge graph context.

2024-09-22.20-03-13.mp4

I'm not entirely sure about the icon choices and would appreciate feedback on UX/UI.

Related issues

part of #8378

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (b29748b) to head (5d7da31).
Report is 96 commits behind head on release/6.4.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #8447      +/-   ##
=================================================
- Coverage          66.23%   66.21%   -0.02%     
=================================================
  Files                597      597              
  Lines              60300    60424     +124     
  Branches            6196     6204       +8     
=================================================
+ Hits               39939    40010      +71     
- Misses             20361    20414      +53     
Flag Coverage Δ
66.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano added the community use to identify PR from community label Sep 24, 2024
@Archidoit Archidoit changed the base branch from master to release/6.4.0 September 24, 2024 13:58
@Archidoit Archidoit self-assigned this Sep 24, 2024
@Archidoit Archidoit self-requested a review September 24, 2024 13:58
@Archidoit
Copy link
Member

Thanks for your PR ! 👍
It's working well, I just added some comments for little code improvements.

@Archidoit
Copy link
Member

Can you also add the translations for the tooltips you added ? ie:

  • Select Child Relationships of Selected Nodes (From)
  • Select Child Relationships of Selected Nodes (To)
  • Deselect Relationships of Selected Nodes
  • Select Relationships of Selected Nodes

@Archidoit
Copy link
Member

Can you also place the new 'select relationships' button just right after the 'select all nodes' button?
In this place :
image

It's because the right part of the toolbar is for actions button (like editing or deleting nodes) whereas the left part is for selection actions.

stefan1anuby added a commit to stefan1anuby/opencti that referenced this pull request Sep 25, 2024
@stefan1anuby
Copy link
Contributor Author

stefan1anuby commented Sep 25, 2024

Can you also add the translations for the tooltips you added ? ie:

  • Select Child Relationships of Selected Nodes (From)
  • Select Child Relationships of Selected Nodes (To)
  • Deselect Relationships of Selected Nodes
  • Select Relationships of Selected Nodes

I used Google Translate; I hope this is okay. Also, changed the button position as requested.

@Archidoit
Copy link
Member

Archidoit commented Sep 25, 2024

Thanks for the changes @stefan1anuby ! Your 2 last commits are not signed so I can't merge the PR... Can you sign them? Thanks

@stefan1anuby
Copy link
Contributor Author

Thanks for the changes @stefan1anuby ! Your 2 last commits are not signed so I can't merge the PR... Can you sign them? Thanks

Done! Thank you for the guidance!

@Archidoit Archidoit merged commit 406755d into OpenCTI-Platform:release/6.4.0 Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove group of relation from container by selecting them from a graph
3 participants