Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Bulk entity creation of SDO/SCO with Copy/Pasting (#4352) #8302

Merged
merged 12 commits into from
Sep 12, 2024

Conversation

ValentinBouzinFiligran
Copy link
Member

@ValentinBouzinFiligran ValentinBouzinFiligran commented Sep 10, 2024

Proposed changes

  • entity type list sorted by name
  • test area scrollable on X
  • default entity type on bulk depending on the tab selected
  • fix bug refresh after entity creation that change entity type for some lines
  • relationships sorted
  • default observable on tab
  • shift click to select before bulk open

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@ValentinBouzinFiligran ValentinBouzinFiligran added the filigran team use to identify PR from the Filigran team label Sep 10, 2024
@ValentinBouzinFiligran ValentinBouzinFiligran changed the title Issue/4352 [frontend] Bulk entity creation of SDO/SCO with Copy/Pasting (#4352) Sep 10, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.94%. Comparing base (9a5f2b3) to head (17c782e).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8302      +/-   ##
==========================================
+ Coverage   66.24%   66.94%   +0.69%     
==========================================
  Files         597      597              
  Lines       60315    60517     +202     
  Branches     6197     6887     +690     
==========================================
+ Hits        39954    40511     +557     
+ Misses      20361    20006     -355     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

In 'create relations in bulk' pop up, bad design if the name is too long (it should not go out of the box name)

image

@Archidoit
Copy link
Member

maybe sort the relationship type list by alphabetical order :
image

@ValentinBouzinFiligran ValentinBouzinFiligran merged commit 974397e into master Sep 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants