Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix shift select for some data tables (#7906) #8292

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Sep 9, 2024

Proposed changes

  • Fix shift select by adding missing id in list queries

Related issues

  • Fix shift select for data tables Update views to new DataTable #7906
    Issue was happening for Attack Patterns, Course of action, external references, tasks, public dashboards, also for feature flagged import files & workbenches lists

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Sep 9, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review September 9, 2024 13:21
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (d9a39c5) to head (3e6a563).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8292      +/-   ##
==========================================
- Coverage   66.23%   66.23%   -0.01%     
==========================================
  Files         597      597              
  Lines       60325    60325              
  Branches     6200     6201       +1     
==========================================
- Hits        39958    39955       -3     
- Misses      20367    20370       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat SouadHadjiat merged commit 7c7b79d into master Sep 9, 2024
6 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/7906-fix-shift-select branch September 9, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants