Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] fixed header colors (#8249) #8277

Merged
merged 1 commit into from
Oct 3, 2024
Merged

[frontend] fixed header colors (#8249) #8277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...te/components/observations/stix_cyber_observables/StixCyberObservableEditionContainer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { useIsEnforceReference } from '../../../../utils/hooks/useEntitySettings
// Do not use it for new code.
const useStyles = makeStyles((theme) => ({
header: {
backgroundColor: theme.palette.background.nav,
backgroundColor: theme.palette.background.default,
padding: '20px 20px 20px 60px',
},
closeButton: {
Expand Down Expand Up @@ -49,7 +49,7 @@ const StixCyberObservableEditionContainer = (props) => {
>
<Close fontSize="small" color="primary" />
</IconButton>
<Typography variant="h6" classes={{ root: classes.title }}>
<Typography variant="subtitle2" classes={{ root: classes.title }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, your fix might work but I think there is a better way :

We do have an internal Drawer component that is using MaterialUI inside.
I think the correct fix is to handle the usages of StixCyberObservableEditionContainer by replacing the old Drawer by the new one. (For example you can look at ReportCreation.tsx to see how we use the new Drawer)

{t_i18n('Update an observable')}
</Typography>
<SubscriptionAvatars context={editContext} />
Expand Down