Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend] filtering-utils fixes and tests #8218

Merged
merged 1 commit into from
Sep 17, 2024
Merged

[backend] filtering-utils fixes and tests #8218

merged 1 commit into from
Sep 17, 2024

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Aug 30, 2024 •
edited
Loading

Proposed changes

  • When using the addFilter function of backend, we want the result filter to be the concatenation of the old filter and a new filter, separated with a AND.
  • add backend tests for functions in filtering-utils

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Aug 30, 2024
@Archidoit Archidoit self-assigned this Aug 30, 2024
@Archidoit Archidoit changed the title [backend] fix backend function adding a filter to a filter group [backend] fix backend function of adding a filter to a filter group Aug 30, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.21%. Comparing base (974397e) to head (0dc0dc2).
Report is 26 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8218      +/-   ##
==========================================
- Coverage   66.21%   66.21%   -0.01%     
==========================================
  Files         597      597              
  Lines       60339    60338       -1     
  Branches     6203     6205       +2     
==========================================
- Hits        39956    39955       -1     
  Misses      20383    20383

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SouadHadjiat
Copy link
Member

what use case does this change fixes exactly? is it possible to write tests?

@Archidoit Archidoit changed the title [backend] fix backend function of adding a filter to a filter group [backend] filtering-utils fixes and tests Sep 11, 2024
@Archidoit Archidoit merged commit 9b9a436 into master Sep 17, 2024
6 checks passed
@Archidoit Archidoit deleted the issue/addFilter branch September 17, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labo-flg labo-flg labo-flg approved these changes

@SouadHadjiat SouadHadjiat Awaiting requested review from SouadHadjiat

Assignees

@Archidoit Archidoit

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Archidoit @SouadHadjiat @labo-flg