Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Add Attack pattern list in Knowledge/Attack pattern with massive operations (#4230) #7996

Merged
merged 18 commits into from
Oct 1, 2024

Conversation

Gwendoline-FAVRE-FELIX
Copy link
Member

Proposed changes

On Matrix View:

  • Add a new online view of the matrix with massive operations
  • Moving the matrix filter
  • Remove "Display only used techniques"

On Kill chain View anc Courses of actions View:

  • Add the matrix name before the category title
  • Remove “Display only used techniques” and “Enable invert colors” (hide it)

Related issues

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 47.76119% with 35 lines in your changes missing coverage. Please review.

Project coverage is 66.23%. Comparing base (841503b) to head (d48bf58).
Report is 1 commits behind head on release/6.4.0.

Files with missing lines Patch % Lines
...ti-platform/opencti-graphql/src/http/httpServer.js 0.00% 11 Missing ⚠️
...i-platform/opencti-graphql/src/config/providers.js 0.00% 10 Missing ⚠️
...latform/opencti-graphql/src/database/middleware.js 10.00% 9 Missing ⚠️
...-platform/opencti-graphql/src/http/httpPlatform.js 0.00% 2 Missing ⚠️
...opencti-graphql/src/manager/notificationManager.ts 71.42% 2 Missing ⚠️
...ti-platform/opencti-graphql/src/graphql/graphql.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #7996      +/-   ##
=================================================
+ Coverage          66.21%   66.23%   +0.02%     
=================================================
  Files                597      597              
  Lines              60430    60441      +11     
  Branches            6205     6205              
=================================================
+ Hits               40011    40031      +20     
+ Misses             20419    20410       -9     
Flag Coverage Δ
66.23% <47.76%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX added the do not merge Do not merge this PR until this tag will be removed label Aug 27, 2024
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX marked this pull request as ready for review September 4, 2024 14:06
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX removed the do not merge Do not merge this PR until this tag will be removed label Sep 5, 2024
@Archidoit
Copy link
Member

In an entity>Knowledge>AttackPattern>Matrix view : there is only one kill chain in the kill chain list, even if other kill chains exist :
image

@Archidoit

This comment was marked as resolved.

@Archidoit

This comment was marked as resolved.

@Gwendoline-FAVRE-FELIX
Copy link
Member Author

But I've got all the Kill chains in the filter.
Kill Chain Filter

@Gwendoline-FAVRE-FELIX
Copy link
Member Author

I've corrected the hover and the name column. As for the display in the kill chain filter, you need to relaunch your frontend for it to be up to date.

@Archidoit

This comment was marked as resolved.

…ded in Techniques / Attack Patterns (#8516) (#8517)

Co-authored-by: Samuel Hassine <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
….15.2 (#8542)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 32b6696 into release/6.4.0 Oct 1, 2024
5 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/4230 branch October 1, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Attack pattern list in Knowledge/Attack pattern with massive operations
7 participants