Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend/e2e] Navigation on groupings and malware analyses (#7378) #7860

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jul 30, 2024

Proposed changes

  • Cover navigation on Groups
  • Cover navigation on Malware analyses

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@aHenryJard aHenryJard changed the title Nav [frontend/e2e] Navigation on groupings (#7378) Jul 30, 2024
@aHenryJard aHenryJard changed the title [frontend/e2e] Navigation on groupings (#7378) [frontend/e2e] Navigation on groupings and malware analyses (#7378) Aug 1, 2024
@labo-flg labo-flg added the filigran team use to identify PR from the Filigran team label Aug 12, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.22%. Comparing base (79d21ee) to head (6382cc0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7860      +/-   ##
==========================================
+ Coverage   66.20%   66.22%   +0.01%     
==========================================
  Files         597      597              
  Lines       60341    60341              
  Branches     6203     6208       +5     
==========================================
+ Hits        39951    39958       +7     
+ Misses      20390    20383       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aHenryJard aHenryJard marked this pull request as ready for review August 28, 2024 09:38
@aHenryJard aHenryJard force-pushed the issue/7378-group-nav branch 2 times, most recently from 4b22163 to 68fd9a0 Compare September 3, 2024 06:39
@labo-flg labo-flg marked this pull request as draft September 9, 2024 07:36
@aHenryJard aHenryJard marked this pull request as ready for review September 9, 2024 14:14
@aHenryJard aHenryJard merged commit b3aa498 into master Sep 11, 2024
6 checks passed
@aHenryJard aHenryJard deleted the issue/7378-group-nav branch September 12, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants