Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix display confidence initial value #6127

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

frapuks
Copy link
Member

@frapuks frapuks commented Feb 27, 2024

Proposed changes

  • Display initial confidence value in update organization update form

Related issues

  • Display nothing value on confidence field

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Process

  • Go to an entities
  • Click on Update
  • Verify the confidence value into confidence form field is valid

@frapuks frapuks self-assigned this Feb 27, 2024
@frapuks frapuks added the filigran team use to identify PR from the Filigran team label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.73%. Comparing base (d9ba571) to head (fa97c81).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6127   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files         540      540           
  Lines       64184    64184           
  Branches     5241     5242    +1     
=======================================
  Hits        42833    42833           
  Misses      21351    21351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have type issues in this component as the type describing the fields of the form does not match the fields of the form. Not especially related to this issue anyway, just for information.

@SarahBocognano
Copy link
Member

Why did you make that change ? Why doest it have to be 0 ?

@frapuks
Copy link
Member Author

frapuks commented Feb 27, 2024

Why did you make that change ? Why doest it have to be 0 ?

Before : Display 0
image

Now : Display confidence value
image

@SarahBocognano : Oh okay it make sense now ^^

@frapuks frapuks merged commit 7fb541e into master Feb 27, 2024
8 checks passed
@frapuks frapuks deleted the issue/form-default-values branch February 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants