Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-branch-deployment: Add the possibility to request upgrading f… #6111

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

sbocahu
Copy link
Member

@sbocahu sbocahu commented Feb 26, 2024

…rom a 5.8 version

Proposed changes

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.74%. Comparing base (18c4db8) to head (458a4ec).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6111      +/-   ##
==========================================
+ Coverage   66.72%   66.74%   +0.01%     
==========================================
  Files         540      540              
  Lines       64180    64180              
  Branches     5240     5242       +2     
==========================================
+ Hits        42827    42834       +7     
+ Misses      21353    21346       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbocahu sbocahu added the do not merge Do not merge this PR until this tag will be removed label Feb 26, 2024
@sbocahu sbocahu force-pushed the featurebranch-upgrade-from-58 branch from f5116bb to 458a4ec Compare February 26, 2024 17:37
@sbocahu sbocahu removed the do not merge Do not merge this PR until this tag will be removed label Feb 26, 2024
@sbocahu
Copy link
Member Author

sbocahu commented Feb 26, 2024

@Kedae tested from a fork; ready for merge IMHO

@Kedae Kedae merged commit 3101813 into master Feb 27, 2024
8 checks passed
@Kedae Kedae deleted the featurebranch-upgrade-from-58 branch February 27, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants