-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] Organization sharing behavior change for upsert and enrichment #6101
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6101 +/- ##
==========================================
+ Coverage 66.57% 66.98% +0.40%
==========================================
Files 540 540
Lines 64270 64297 +27
Branches 5222 5776 +554
==========================================
+ Hits 42788 43069 +281
+ Misses 21482 21228 -254 ☔ View full report in Codecov by Sentry. |
cdc32a6
to
6368e31
Compare
Connecteurs testés :
|
@@ -190,10 +191,12 @@ export const askElementEnrichmentForConnector = async (context, user, enrichedId | |||
const message = { | |||
internal: { | |||
work_id: work.id, // Related action for history | |||
applicant_id: user.id, // User asking for the import | |||
applicant_id: null, // No specific user asking for the import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we set the applicant_id to the connector user id if we want the enrichment update to have the connector as the creator?
Tested OK when it comes to keeping the organization sharing during enrichment, and applying the organization sharing to objects created during enrichment.
|
Organization sharing behavior change for upsert and enrichment
Linked to PRs
OpenCTI-Platform/client-python#568
OpenCTI-Platform/connectors#1859