Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Cannot add tag to a dashboard/investigation (#5861) #6063

Merged
merged 7 commits into from
Feb 27, 2024
Merged

[frontend] Cannot add tag to a dashboard/investigation (#5861) #6063

merged 7 commits into from
Feb 27, 2024

Conversation

SarahBocognano
Copy link
Member

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.67%. Comparing base (d35155b) to head (3f5f0b6).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6063      +/-   ##
==========================================
+ Coverage   66.66%   66.67%   +0.01%     
==========================================
  Files         540      540              
  Lines       64256    64256              
  Branches     5242     5244       +2     
==========================================
+ Hits        42838    42845       +7     
+ Misses      21418    21411       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBocognano SarahBocognano self-assigned this Feb 21, 2024
@SarahBocognano SarahBocognano added the filigran team use to identify PR from the Filigran team label Feb 21, 2024
@Kedae
Copy link
Member

Kedae commented Feb 21, 2024

Can we have a small e2e test for that ? :)

@SarahBocognano SarahBocognano force-pushed the issue/5861 branch 2 times, most recently from a08bb56 to 416b032 Compare February 27, 2024 13:34
@CelineSebe
Copy link
Member

it works

frapuks
frapuks reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@frapuks frapuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just linters issues, but feature work perfectly

opencti-platform/opencti-front/tests_e2e/dashboard/createDashboard.spec.ts Outdated Show resolved Hide resolved
marieflorescontact
marieflorescontact reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@marieflorescontact marieflorescontact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locally tested ok 👌

@Kedae Kedae merged commit abcd144 into master Feb 27, 2024
8 checks passed
@Kedae Kedae deleted the issue/5861 branch February 27, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marieflorescontact marieflorescontact marieflorescontact left review comments

@frapuks frapuks frapuks left review comments

@Kedae Kedae Kedae approved these changes

Assignees

@SarahBocognano SarahBocognano

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SarahBocognano @Kedae @CelineSebe @marieflorescontact @frapuks