Merge pull request #32 from OpenBuildings/check-url-attr

Fix JS error in console - check if href attribute is present
OpenBuildings · May 19, 2020 · 662d693 · 662d693
2 parents 1977644 + c7c51f8
commit 662d693
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/web/js/general.js b/web/js/general.js
@@ -93,13 +93,17 @@ $(function(){
 
 	$('body').on('click', '[data-toggle="modal"]', function(e) {
 		e.preventDefault();
-		var url = $(this).attr('href');
-		if (url.indexOf('#') === 0) {
-			$(url).modal('open');
-		} else {
-			$.get(url, function(data) {
-				$('<div class="modal hide fade">' + data + '</div>').modal();
-			}).success(function() { $('input:text:visible:first').focus(); });
+		const url = $(this).attr('href');
+		if (typeof url !== typeof undefined) {
+			if (url.indexOf('#') === 0) {
+				$(url).modal('open');
+			} else {
+				$.get(url, function (data) {
+					$('<div class="modal hide fade">' + data + '</div>').modal();
+				}).success(function () {
+					$('input:text:visible:first').focus();
+				});
+			}
 		}
 	});