Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polish scale #173

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Agilulfo
Copy link

@Agilulfo Agilulfo commented Sep 17, 2024

Initial draft changes to add the polish scale a.k.a. kurtyka scale
implements: #172

TODO:

  • Add polish scale to csv file
  • Update Readme
  • Add polish scale implementation : src/scales/polish.ts
  • reference scale in : src/scales/index.ts
  • Add tests
  • Generate json file
  • Document how to add a scale

Copy link

github-actions bot commented Sep 17, 2024

Coverage report

Caution

Coverage does not meet threshold
Statements coverage not met for global: expected <=999999 not covered statements, but got 624

St.
Category Percentage Covered / Total
🟢 Statements
84.1% (-3.38% 🔻)
624/742
🟡 Branches
64.36% (-3.18% 🔻)
130/202
🟡 Functions
76.1% (-3.77% 🔻)
121/159
🟢 Lines
83.16% (-3.5% 🔻)
573/689
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴 scales/polish.ts 27.91% 9.09% 22.22% 26.83%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢 index.ts 100% 100%
35% (-1.84% 🔻)
100%

Test suite run success

270 tests passing in 18 suites.

Report generated by 🧪jest coverage report action from 0889500

src/data/routes.csv Outdated Show resolved Hide resolved
@musoke
Copy link
Collaborator

musoke commented Sep 18, 2024

This looks like you're on the right path! Let us know if you need help.

@Agilulfo
Copy link
Author

@musoke thank you!
It might take me a while since I'm picking typescript as I go on my spare time.
Will let you know when it is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants