Skip to content

Commit

Permalink
stream response for progressive rendering
Browse files Browse the repository at this point in the history
also: deploy when pushing "straging" branch along with "develop"
  • Loading branch information
enapupe committed Nov 3, 2023
1 parent 40f6712 commit 05d554d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy-staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Publish to dockerhub and perform a deploy on cloud run

on:
push:
branches: ["develop"]
branches: ["develop", "staging"]

jobs:
build-and-push-image:
Expand Down
16 changes: 8 additions & 8 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ app.get("*", async (req, res) => {
.send("upstream server did not respond with a valid status code");
}

const processedImage = await sharp(data)
.rotate()
.resize({ width, height })
.toFormat(format, { quality });

return res
res
.set("Cache-Control", "public, max-age=15552000")
.set("Vary", "Accept")
.type(`image/${format}`)
.send(await processedImage.toBuffer());
.type(`image/${format}`);

sharp(data)
.rotate()
.resize({ width, height })
.toFormat(format, { quality, progressive: true })
.pipe(res);
} catch (e) {
return res.status(500).send(JSON.stringify(e));
}
Expand Down

0 comments on commit 05d554d

Please sign in to comment.