-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement internal strlcpy to replace the strncpy #620
Open
arnopo
wants to merge
3
commits into
OpenAMP:main
Choose a base branch
from
arnopo:strcpy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
* | ||
* Copyright (c) 2024, STMicroelectronics | ||
* | ||
*/ | ||
|
||
#include <string.h> | ||
|
||
/** | ||
* @internal | ||
* | ||
* @brief Copies a string to a destination buffer with size limitation and returns the length of | ||
* the source string. | ||
* | ||
* This function copies up to `size - 1` characters from the source string `src` | ||
* to the destination buffer `dest`, ensuring that the destination buffer is | ||
* null-terminated. The function returns the length of the source string `src`. | ||
* If the length of `src` is greater than or equal to `size`, the destination | ||
* buffer will be truncated. | ||
* | ||
* @param dst Destination buffer where the string will be copied. | ||
* @param src Source string to be copied. | ||
* @param size Size of the destination buffer. | ||
* @return The length of the source string `src`. | ||
* | ||
* @note If the size of the destination buffer is 0, the function does not copy any characters and | ||
* the destination buffer is not null-terminated. | ||
* @note The function ensures that the destination buffer is always null-terminated if `size` is | ||
* greater than 0. | ||
* @note: this code is inspired from the strlcpy.c file from freeBSD . | ||
*/ | ||
size_t strlcpy(char *dest, const char *src, size_t size); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
collect (PROJECT_LIB_SOURCES string.c) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* SPDX-License-Identifier: BSD-3-Clause | ||
* | ||
* Copyright (c) 2024, STMicroelectronics | ||
* | ||
*/ | ||
|
||
#include <internal/string.h> | ||
#include <metal/io.h> | ||
|
||
metal_weak size_t strlcpy(char *dst, const char *src, size_t size) | ||
{ | ||
size_t nleft = size; | ||
|
||
/* Copy as many bytes as will fit. */ | ||
if (nleft != 0) { | ||
while (--nleft != 0) { | ||
*dst = *src++; | ||
if (*dst++ == '\0') | ||
break; | ||
} | ||
} | ||
|
||
/* Not enough room in dst, add NUL and traverse rest of src. */ | ||
if (nleft == 0 && size != 0) | ||
*dst = '\0'; /* NUL-terminate dst */ | ||
|
||
return strlen(src); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many RTOS support strlcpy need some method to remove string.c or strlcpy from build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see a potential failure in not using this RTOS strlcpy implementation?
perhaps defining is a weak function would answer to your concern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link will report the multiple instance error if RTOS provide one implementation.
Yes, it's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weak attribute added