openamp: replace all strncpy to strlcpy #602
Conversation
strlcpy is more convenient and safer than strncpy Signed-off-by: Yongrong Wang <[email protected]>
|
It seems that strlcpy is only available recently in glibc, or I'm wrong? |
| @@ -141,7 +141,7 @@ int rpmsg_send_ns_message(struct rpmsg_endpoint *ept, unsigned long flags) | |||
|
|
|||
| ns_msg.flags = flags; | |||
| ns_msg.addr = ept->addr; | |||
| strncpy(ns_msg.name, ept->name, sizeof(ns_msg.name)); | |||
| strlcpy(ns_msg.name, ept->name, sizeof(ns_msg.name)); | |||
There was a problem hiding this comment.
ept->name is safe as already truncated in rpmsg_register_endpoint, we could use a memcpy here.
| @@ -305,7 +305,7 @@ void rpmsg_register_endpoint(struct rpmsg_device *rdev, | |||
| rpmsg_ept_cb cb, | |||
| rpmsg_ns_unbind_cb ns_unbind_cb, void *priv) | |||
| { | |||
| strncpy(ept->name, name ? name : "", sizeof(ept->name)); | |||
| strlcpy(ept->name, name ? name : "", sizeof(ept->name)); | |||
There was a problem hiding this comment.
I wonder if we should create our own strncpy.
we could create a libutil/strncpy.c that contains a safe_strncpy function.
char *safe_strncpy(char *dest, char *src, size_t size) {
size_t len;
if (size == 0) {
dest[0] = '\0';
} else {
len = strnlen(src, size - 1);
memcpy(dest, src, len);
dest[len] = '\0';
}
return dest;
}@edmooring, @tnmysh : any opinon/suggestion?
There was a problem hiding this comment.
I believe that makes sense. In kernel as well, strlcpy was deprecated, and strscpy was introduced. https://www.kernel.org/doc/html/latest/core-api/kernel-api.html?highlight=declare_bitmap#c.strscpy
There was a problem hiding this comment.
I am okay, to introduce such function.
This ops can do in rpmsg without coupling to virtio. Signed-off-by: wangyongrong <[email protected]>
| @@ -55,6 +55,7 @@ typedef void (*rpmsg_ept_release_cb)(struct rpmsg_endpoint *ept); | |||
| typedef void (*rpmsg_ns_unbind_cb)(struct rpmsg_endpoint *ept); | |||
| typedef void (*rpmsg_ns_bind_cb)(struct rpmsg_device *rdev, | |||
| const char *name, uint32_t dest); | |||
| typedef int (*rpmsg_notify_wait_cb)(struct rpmsg_device *rdev, uint32_t id); | |||
There was a problem hiding this comment.
Please introduce this commit in a new PR, you also need to provide more information to explain why you need this update.
No description provided.