CI: Zephyr: Get latest version of the zephyr sdk #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid having any misalignment between Zephyr and the SDK during CI tests, consider getting the latest version of the Zephyr SDK automatically instead of hardcoding it. This approach should ensure that the latest version of sdk is always used. Signed-off-by: Arnaud Pouliquen <[email protected]>
wmamills
reviewed
Oct 25, 2023
| ZEPHYR_SDK_SETUP_DIR=zephyr-sdk-$ZEPHYR_SDK_VERSION | ||
| ZEPHYR_SDK_SETUP_TAR=${ZEPHYR_SDK_SETUP_DIR}_linux-x86_64.tar.xz | ||
| ZEPHYR_SDK_DOWNLOAD_URL=$ZEPHYR_SDK_DOWNLOAD_FOLDER/$ZEPHYR_SDK_SETUP_TAR | ||
| ZEPHYR_SDK_API_FOLDER=https://api.github.com/repos/zephyrproject-rtos/sdk-ng/releases/latest |
There was a problem hiding this comment.
Will latest ever point to an -rcN release? If so is that a good thing or not?
There was a problem hiding this comment.
Will latest ever point to an -rcN release? If so is that a good thing or not?
Yes it could I suppose. The risk is regression. I propose to test it in this way and come back to a hardcoded version in case of issue.
|
I am integrating it so that the CI works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid having any misalignment between Zephyr and the SDK during CI tests, consider getting the latest version of the Zephyr SDK automatically instead of hardcoding it.
This approach should ensure that the latest version of sdk is always used.