Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enforce more lint rules in codebase #101

Merged
merged 36 commits into from
Sep 4, 2024
Merged

refactor: enforce more lint rules in codebase #101

merged 36 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. feat: add ruff.toml

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6cda070 View commit details
    Browse the repository at this point in the history

  2. treewide: format gamefix modules through ruff 

    - Enforces single quotes, a line length of 88, and updates the format of comment
    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    54e60d4 View commit details
    Browse the repository at this point in the history

  3. treewide: remove 'pylint: disable=C0103' from gamefixes

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    71a6c54 View commit details
    Browse the repository at this point in the history

  4. treewide: format python files through ruff

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    489cafa View commit details
    Browse the repository at this point in the history

  5. treewide: remove all pylint disables

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    09690ba View commit details
    Browse the repository at this point in the history

  6. __init__: remove unused import

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e8286b6 View commit details
    Browse the repository at this point in the history

  7. __init__: don't use bare except

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    55a0152 View commit details
    Browse the repository at this point in the history

  8. debug: don't log system python version

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7a48344 View commit details
    Browse the repository at this point in the history

  9. tools: delete lint.sh

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f27e20c View commit details
    Browse the repository at this point in the history

  10. workflows: lint through ruff

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    06676a7 View commit details
    Browse the repository at this point in the history

  11. ruff.toml: add ANN rule to enforce typings

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    03e584f View commit details
    Browse the repository at this point in the history

  12. ruff.toml: exclude test file

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7243f73 View commit details
    Browse the repository at this point in the history

  13. treewide: add return type for all gamefixes

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b91cb77 View commit details
    Browse the repository at this point in the history

  14. steamhelper: prefer using f-string

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    59df5a7 View commit details
    Browse the repository at this point in the history

  15. config: fix missing types

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3722c0f View commit details
    Browse the repository at this point in the history

  16. check_gamefixes: fix missing type

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    70cf003 View commit details
    Browse the repository at this point in the history

  17. util: fix reference to cache directory

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    28f0c9d View commit details
    Browse the repository at this point in the history

  18. util: add missing types to functions

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    64cb086 View commit details
    Browse the repository at this point in the history

  19. util: fix types for function calls

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e37f23c View commit details
    Browse the repository at this point in the history

  20. workflows: fix lint step

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    98e83d2 View commit details
    Browse the repository at this point in the history

  21. workflows: lint winetricks

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    27b1c8a View commit details
    Browse the repository at this point in the history

  22. util: use Union type instead of pipe

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7a20176 View commit details
    Browse the repository at this point in the history

  23. ruff.toml: add FLY, ARG, and UP rules

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fc249a6 View commit details
    Browse the repository at this point in the history

  24. treewide: use built in open

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    899bf62 View commit details
    Browse the repository at this point in the history

  25. treewide: remove unnecessary open mode

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    e02a578 View commit details
    Browse the repository at this point in the history

  26. treewide: fix deprecated imports

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7ee6534 View commit details
    Browse the repository at this point in the history

  27. util: prefer OSError over IOError 

    - Use OSError directly as advised in UP024 from ruff
    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5565c37 View commit details
    Browse the repository at this point in the history

  28. ruff.toml: add pydocstyle rule

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    1be7847 View commit details
    Browse the repository at this point in the history

  29. treewide: enforce pydocstyle for *.py files

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2012505 View commit details
    Browse the repository at this point in the history

  30. treewide: enforce pydocstyle for gamefixes

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    86ad08a View commit details
    Browse the repository at this point in the history

  31. ruff.toml: add lint exceptions

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ed2d10a View commit details
    Browse the repository at this point in the history

  32. treewide: ruff lint

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    99bfc5d View commit details
    Browse the repository at this point in the history

  33. debug: fix type when printing sys.argv

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    958d5d8 View commit details
    Browse the repository at this point in the history

  34. ruff.toml: enforce D211 rule

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0c467b8 View commit details
    Browse the repository at this point in the history

  35. gamefixes-steam: ruff format

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    dc754ba View commit details
    Browse the repository at this point in the history

  36. gamefixes-steam: fix invalid steam appid on rebase

    @R1kaB3rN
    R1kaB3rN committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8a5a80c View commit details
    Browse the repository at this point in the history