Update launcher and packaging #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For now, execute the launcher within the Flatpak sandbox. Breaking out the sandbox via flatpak-spawn is discouraged and breaks Flatpak's security model. It may also require other Flatpak applications to make additional changes in their manifest, which they may not be supportive to do for this practice. Unless necessary or proven to be very problematic, execute within the Flatpak sandbox
- To run games, the only required files to be in the user's home directory is the runtime platform and the reaper executable. The launcher files will remain in their system path that's been configured in build time.
- The directory /usr/share/steam/compatibilitytool.d is an official system path supported by Valve's Steam client to search for community-based tools and to use them as compatibility tools to run games. Instead of copying the umu-launcher directory to ~/.local/share/Steam/compatibilitytool.d we can install it in its system path. That way, there's less to copy/remove and the files there can be managed by the distribution's package manager
- The system path compatibilitytools.d directory will be used instead
- The launcher only needs this directory to write Proton. For now, just limit access to this directory instead of exposing user's entire ~/.local/share
- For now, hide this tool in the Steam client until the umu runtime platform is released. - Related to Open-Wine-Components#4
- Reaper can be executed directly from the system path. All we need in the home directory is the runtime platform
- While those files will not be copied anymore, we still need to update them in umu_version.json if we want the configuration files to be in sync
R1kaB3rN
force-pushed
the
flatpak-update
branch
from
01bfdb4
to
fc157b0
Compare
- Update the tests to account for the launcher files, umu-launcher and reaper not being copied to the home directory. Those files will remain in their system path defined at buid time, which makes the umu_version.json in ~/.local/share/umu and the runtime platform the only files in ~/.local/share/umu.
R1kaB3rN
force-pushed
the
flatpak-update
branch
from
98808b6
to
6d943b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes few changes in the launcher and the launcher's packaging. Only the
umu_version.jsonconfiguration file will be copied to the user's home directory, and theumu-launchercompatibilitytool will be installed in Valve's official system path. The configuration file and the runtime platform are the only files needed in the home directoy to execute games.In addition, the
umu-launchercompatibility tool will remain hidden for now until umu has built its custom runtime. The umu Flatpak's access to~/.local/shareis now limited to~/.local/share/Steaminstead of exposing the entire directory. This is good for security, and the launcher only requires~/.local/share/Steamto write Proton. If the launcher ever needs more access to files, such as~/.local/share/lutris, the manifest should be changed to allow them.