Fix CI #46
Merged
Fix CI #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We don't copy symlinks anymore and if there happens to be a symlink when copying a directory tree, it's handled via copyfile_reflink
- We do not want to call this in the tests when setting up ulwgl
…hare/ULWGL - Previously, when ulwgl-run was installed at /usr/bin, it failed to refer to link's target directory. To refer to /usr/share/ULWGL we need the resolved parent of the symbolic link
- curl is a dependency for Steam along with Zenity, so it is guaranteed to be on the user's system
- We do not need to copy shell scripts as we've successfully resolved the root
- Since ulwgl-run points to the script's parent directory /usr/share/ULWGL, successfully running the script results in the following pressure vessel error: Binding directories that are located under '/usr/' is not supported!. - To prevent this error, we need to reference ~/.local/share/ULWGL instead.
- We create the symbolic link ulwgl-run dynamically on launch when installing or updating at ~/.local/share/Steam/compatibilitytools.d/ULWGL-Launcher and ~/.local/share/ULWGL. To account for distributions that may not install the package to /usr/share/ULWGL, these links refer to the relative paths in ~/.local/share.
…_TOOL_PATHS values
- The root configuration file has already been read and abstracted as a Dictionary in the previous context, so just pass the reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CI and applies various fixes/improvements