Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsing configuration files a plugin #38

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

R1kaB3rN
Copy link
Member

@R1kaB3rN R1kaB3rN commented Feb 20, 2024

Closes #37

This PR separates the config file functionality as a plugin from the core program to make it run on some distributions (e.g. Ubuntu LTS). tomllib will be dynamically imported, optional and in the event the user tries to use the --config flag, an error will be raised to warn them of the Python requirement.

cc @loathingKernel for the Github Action

@R1kaB3rN R1kaB3rN marked this pull request as draft February 21, 2024 00:04
@R1kaB3rN R1kaB3rN force-pushed the toml-plugin branch 3 times, most recently from ba0ec06 to 94109c3 Compare February 21, 2024 00:13
@R1kaB3rN R1kaB3rN marked this pull request as ready for review February 21, 2024 00:14
@loathingKernel
Copy link
Contributor

That was fast! I would suggest to add all versions from 3.7 onwards since lutris supports them.

@R1kaB3rN
Copy link
Member Author

That was fast! I would suggest to add all versions from 3.7 onwards since lutris supports them.

We could test that far, but is it fine to use Lutris as our baseline? They must have different requirements to test that far

@loathingKernel
Copy link
Contributor

We could test that far, but is it fine to use Lutris as our baseline? They must have different requirements to test that far

Since lutris uses ulwgl i would say yes. We lose nothing doing it anyways. Better be safe.

.github/workflows/ulwgl-python.yml Outdated Show resolved Hide resolved
.github/workflows/ulwgl-python.yml Outdated Show resolved Hide resolved
@R1kaB3rN
Copy link
Member Author

R1kaB3rN commented Feb 21, 2024

We could test that far, but is it fine to use Lutris as our baseline? They must have different requirements to test that far

Since lutris uses ulwgl i would say yes. We lose nothing doing it anyways. Better be safe.

While we have nothing to lose, I don't quite agree with that logic and would prefer that we have more precise reasons for testing that far

Also, if we really want to decisively solve this problem, we have the Flatpak to bundle dependencies that will cover not only Python, but Mesa and Vulkan which DXVK has hard minimum requirements for. But luckily, Jammy sources the minimum Mesa for to use DXVK for gaming to not be a big problem for those users

@R1kaB3rN R1kaB3rN force-pushed the toml-plugin branch 7 times, most recently from ecc47ba to 79da459 Compare February 21, 2024 03:02
@loathingKernel
Copy link
Contributor

loathingKernel commented Feb 21, 2024

But luckily, Jammy sources the minimum Mesa for to use DXVK for gaming to not be a big problem for those users

Imho the Mesa version requirement for DXVK is irrelevant. Someone might choose to use the OpenGL renderer for whatever reason, or install and use things like gallium nine (I have not tested that option with Proton but you get the point). Someone else might want to chip in here though.

@R1kaB3rN R1kaB3rN marked this pull request as draft February 21, 2024 17:11
@R1kaB3rN R1kaB3rN marked this pull request as ready for review February 21, 2024 17:58
@R1kaB3rN R1kaB3rN merged commit b97c9af into Open-Wine-Components:main Feb 22, 2024
3 checks passed
@R1kaB3rN R1kaB3rN deleted the toml-plugin branch March 9, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runner using libs not available in Python < 3.11 causing ModuleNotFoundError
2 participants