refactor: use context managers whenever to manage resources #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensures that in the process of configuring the gamescope windows or creating the subprocess, system resources will be released
R1kaB3rN
force-pushed
the
context-managers
branch
from
b0f2be2
to
466a0db
Compare
- libc.so is fundamental, so do not even test for this. Users are going to run into problems if it somehow couldn't be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on SteamOS (3.16.13) and on the latest Steam beta client (1726256783) for regressions.
This PR refactors some code to use context managers whenever possible, so system resources are properly released when the launcher is forcefully killed any time in its lifecycle. In particular, when the launcher is interrupted before the thread pool is shutdown or before the file descriptors of python-xlib objects are closed during the gamescope window setup.
TODO: