fix: depend on ldconfig when finding shared library path prefixes #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R1kaB3rN
force-pushed
the
fix-steamrt-paths
branch
2 times, most recently
from
ccfd4f7
to
c24841e
Compare
- The previous implementation of finding the shared library paths assumed every path containing the libc.so.6 was a valid path prefix. However, it's not that simple as it would be wrong for container environments such as Flatpak where an LD_LIBRARY_PATH is not set and shared library paths appear in multiple places, resulting in the incorrect environment variable for STEAM_RUNTIME_LIBRARY_PATH: STEAM_RUNTIME_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu:/app/lib/i386-linux-gnu:/home/foo/Games/Flowers - Le Volume Sur Automne Where it really should be *all* the paths that appear in the dynamic linker's search path: STEAM_RUNTIME_LIBRARY_PATH=/usr/lib/x86_64-linux-gnu:/app/lib/i386-linux-gnu:/app/lib32:/app/lib/i386-linux-gnu/GL/default/lib:/lib64:/app/lib:/usr/lib/x86_64-linux-gnu/GL/default/lib:/usr/lib/x86_64-linux-gnu/openh264/extra:/usr/lib/i386-linux-gnu:/home/foo/Games/Flowers - Le Volume Sur Automne - Note, this problem hasn't been reported yet and it's not clear how it would effect games by having some paths missing yet. Nonetheless, the value was incorrect when matching against Steam's (Flatpak) STEAM_RUNTIME_LIBRARY_PATH value. As a result, minus the appended Scout runtime paths, the value for that environment variable will now be logically equivalent to Steam's as we are using the paths prefixes returned from ldconfig then resolving those real paths.
- libc.so is fundamental and users are going to run into problems if it couldn't be found by Python from the host or container environment. Those users will need to configure their environment accordingly within the container framework's expectations. In the next lines, umu-launcher will attempt to find the paths using ldconfig instead of exiting early if libc.so couldn't be found
R1kaB3rN
force-pushed
the
fix-steamrt-paths
branch
from
c24841e
to
899d124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.