Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system call failures when running winetricks verbs #115

Merged
merged 2 commits into from
Jun 30, 2024

Commits on Jun 30, 2024

  1. umu_run: remove winetricks environment variables

    - Currently, winetricks verbs are being applied to the wine prefix by executing the winetricks script as an executable for Proton. For some reason, this results in system calls failing for container binaries such as grep and sed, which are required by winetricks for parsing. Here's an example of grep's coredump:
    
    Stack trace of thread 52329:
    0  0x000070003275383b n/a (/lib/ld-linux-x86-64.so.2 + 0x2183b)
    1  0x000070003274e0f8 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c0f8)
    2  0x000070003274f9be n/a (/lib/ld-linux-x86-64.so.2 + 0x1d9be)
    3  0x000070003274e748 n/a (/lib/ld-linux-x86-64.so.2 + 0x1c748)
    ELF object binary architecture: AMD x86-64
    
    While this doesn't appear to impact the application of winetricks verbs to the prefix nor has there been reports of this problem yet, as a precaution, we should set these environment variables from the proton script and replicate protonfixes' execution. As a result, there should be no more coredumps except from wine64-preloader, which should be normal, and the launcher will only guard against valid winetricks verbs
    R1kaB3rN committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    0e27297 View commit details
    Browse the repository at this point in the history
  2. umu_test: update test

    R1kaB3rN committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    4adbae7 View commit details
    Browse the repository at this point in the history