Add functionality to use winetricks #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Solely as an FYI, stable versions of Proton up to Proton 8 used different paths
I don't think this is something that should be accounted for necessarily, but it is good to know if someone files an issue at some point trying to run winetricks with an older Proton version.
- Without these variables set, winetricks will be missing and will result in a 'ShellExecuteEx failed: File not found' error.
- Allows passing verbs separated by spaces to apply verbs in bulk to the prefix
- It doesn't make sense to check if the value in the log file is a verb and not the input.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for executing winetricks without writing a protonfix module or using the winetricks GUI via GAMEID=winetricks-gui.
Example Usages:
Edit: Changing the layout of the filesystem via bwrap to use the system winetricks needs more discussion and exploration. This case is only relevant when using Valve's Proton builds, and it'll require having Steam running in the background and writing a file that contains an app ID in a folder. Of course, this is not good as it will probably require installing Steam which is contrary to goals of this project. GE-Proton and UMU-Proton builds are not effected by this, and have patches that solve those problems. Launchers such as Heroic or Lutris can workaround this issue but for umu, unless there's a way to workaround those two problems without installing Steam, this feature will need to wait.