[FEAT] 선택한 구역에 대한 프로젝트, 프로필 카드 리스트 랜덤 조회 API, 프로젝트 매칭 요청 생성 API 개발 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jectTag와의 조인 로직 추가
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit c012a47. ♻️ This comment has been updated with latest results. |
JIN-076
changed the title
…pen-Eye-Im-Developer/MoGakGo-BE into feat/#30-cards_list_up_by_zone
…into feat/#30-cards_list_up_by_zone # Conflicts: # src/main/java/io/oeid/mogakgo/domain/project_join_req/infrastructure/ProjectJoinRequestJpaRepository.java
tidavid1
reviewed
Feb 19, 2024
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| @Schema(description = "회원 프로필 조회 응답") | |||
| @Getter | |||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | |||
| @AllArgsConstructor(access = AccessLevel.PUBLIC) | |||
There was a problem hiding this comment.
Suggested change
| @AllArgsConstructor(access = AccessLevel.PUBLIC) | |
| @AllArgsConstructor |
| @UserId Long userId, @Valid @RequestBody ProjectJoinCreateReq request | ||
| ) { | ||
| return ResponseEntity.status(201) | ||
| .body(ProjectJoinRequestAPIRes.from(projectJoinRequestService.create(userId, request))); |
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| @RestController | ||
| @RequestMapping("/api/v1/project-join-request") |
There was a problem hiding this comment.
project-join-request 보다 project/join-request는 어떨까요?
Comment on lines
+45
to
+77
| private User validateToken(Long userId) { | ||
| return userRepository.findById(userId) | ||
| .orElseThrow(() -> new UserException(USER_NOT_FOUND)); | ||
| } | ||
|
|
||
| private void validateSender(User tokenUser, Long userId) { | ||
| if (!tokenUser.getId().equals(userId)) { | ||
| throw new ProjectJoinRequestException(PROJECT_JOIN_REQUEST_FORBIDDEN_OPERATION); | ||
| } | ||
| } | ||
|
|
||
| private Project validateProjectExist(Long projectId) { | ||
| return projectRepository.findById(projectId) | ||
| .orElseThrow(() -> new ProjectException(PROJECT_NOT_FOUND)); | ||
| } | ||
|
|
||
| private void validateProjectCreator(Project project, Long userId) { | ||
| if (project.getCreator().getId().equals(userId)) { | ||
| throw new ProjectJoinRequestException(PROJECT_JOIN_REQUEST_FORBIDDEN_OPERATION); | ||
| } | ||
| } | ||
|
|
||
| private void validateAlreadyExistRequest(Long userId, Long projectId) { | ||
| if (projectJoinRequestRepository.findAlreadyExists(userId, projectId).isPresent()) { | ||
| throw new ProjectJoinRequestException(PROJECT_JOIN_REQUEST_ALREADY_EXIST); | ||
| } | ||
| } | ||
|
|
||
| private void validateUserCertRegion(Project project, User tokenUser) { | ||
| if (!tokenUser.getRegion().equals(project.getCreatorInfo().getRegion())) { | ||
| throw new ProjectJoinRequestException(INVALID_PROJECT_JOIN_REQUEST_REGION); | ||
| } | ||
| } |
| private final MeetingInfoResponse meetingInfo; | ||
|
|
||
|
|
||
| public ProjectDetailAPIRes(Long projectId, UserPublicApiResponse creator, |
There was a problem hiding this comment.
QueryDsl에서 Projections.constructor를 사용해서 바인딩받을 때 생성자를 사용하기 때문에 public으로 열어두어야 해서 이렇게 작성했습니다!
| @Schema(description = "프로젝트 만남 장소", example = "맥심플랜트 이태원점") | ||
| private final String meetDetail; | ||
|
|
||
| public MeetingInfoResponse(LocalDateTime meetStartTime, LocalDateTime meetEndTime, String meetDetail) { |
There was a problem hiding this comment.
밑에 팩토리 메서드가 있는데 퍼블릭으로 있는 이유가 궁금해요!
Comment on lines
+125
to
+126
| // 요청할 때마다 랜덤 정렬 | ||
| Collections.shuffle(projects.getData()); |
| @Valid @ModelAttribute CursorPaginationInfoReq pageable | ||
| ) { | ||
| return ResponseEntity.ok().body( | ||
| profileCardService.getRandomOrderedProfileCardsByRegion(userId, region, pageable) |
happyjamy
approved these changes
Feb 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개발 사항
이슈 번호
특이 사항 🫶