Feat/#69 프로젝트 취소 기능 구현 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 224024f. |
tidavid1
reviewed
Feb 18, 2024
tidavid1
approved these changes
Feb 18, 2024
There was a problem hiding this comment.
서비스마다 중복되는 getUser 메서드를 방지하고자 UserCommonService에 유저 조회 메서드를 구현했습니다. 이를 사용하면 좋을 것 같아요!
| @UserId Long userId, @PathVariable Long id | ||
| ) { | ||
| projectService.cancel(userId, id); | ||
| return ResponseEntity.status(200).body(ProjectIdRes.from(id)); |
There was a problem hiding this comment.
ResponseEntity.ok().body(ProjectIdRes.from(id)); 대신 ..status(200) 쓴 이유가 궁금해요!
There was a problem hiding this comment.
딱히 이유는 없어용 ㅎㅅㅎ 저는 body 가 있을때는 상태코드를 명시하는 편이라... 일괄로 맞춰야 하면 맞추겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 개발 사항
프로젝트 취소 기능 구현
이슈 번호
특이 사항 🫶